You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The Table page currently has two non-localized strings, written in English instead of Portuguese when Portuguese is the selected language:
Describe the solution you'd like
These two strings, Search: and Showing 1 to 14 of 14 entries, are localized and adapted to the domain. As a suggestion, leveraging DataTables and Laravel features, I would change the following files as follows:
'list' => [
'no-data' => 'Sem registo de incêndios',
'data' => 'A mostrar :number incêndio|A mostrar :number incêndios',
'data-filtered' => 'A mostrar :number incêndio (filtrado de um total de :total)|A mostrar :number incêndios (filtrado de um total de :total)',
'search' => 'Pesquisar'
]
'list' => [
'no-data' => 'No fire incidents',
'data' => 'Showing :number fire incident|Showing :number fire incidents',
'data-filtered' => 'Showing :number fire incident (filtered from a total of :total)|Showing :number fire incidents (filtered from a total of :total)',
'search' => 'Search'
]
I suggest simplifying the string for table entries, given that the table is not paged. Also, given that I have no experience with Laravel, I'm not sure if there is a simpler approach to combining it with DataTables.
Let me know what you think and if I can open a PR. Thanks!
Hi! 👋
Is your feature request related to a problem? Please describe.
The Table page currently has two non-localized strings, written in English instead of Portuguese when Portuguese is the selected language:
Describe the solution you'd like
These two strings,
Search:
andShowing 1 to 14 of 14 entries
, are localized and adapted to the domain. As a suggestion, leveraging DataTables and Laravel features, I would change the following files as follows:fogospt/fogospt/resources/lang/pt/pages.php
Lines 103 to 105 in c460e44
fogospt/fogospt/resources/lang/en/pages.php
Lines 90 to 92 in c460e44
fogospt/fogospt/resources/views/table.blade.php
Lines 58 to 73 in c460e44
This way, the final result will look like this:
small.mov
I suggest simplifying the string for table entries, given that the table is not paged. Also, given that I have no experience with Laravel, I'm not sure if there is a simpler approach to combining it with DataTables.
Let me know what you think and if I can open a PR. Thanks!
Additional context
References
The text was updated successfully, but these errors were encountered: