Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean translation is finished 🥰 #22

Open
rivercory opened this issue Aug 16, 2024 · 5 comments · Fixed by #21
Open

Korean translation is finished 🥰 #22

rivercory opened this issue Aug 16, 2024 · 5 comments · Fixed by #21

Comments

@rivercory
Copy link

2024-08-16 23 58 02 crowdin com dd78d85f0b70
@joshika39
Korean translation is now fully added!
Please apply the Korean translation to your website :)

@joshika39
Copy link
Member

@rivercory

Thanks for your contribution and for letting me know! I'll update the website tomorrow afternoon!

Best regards,
Joshua

@joshika39
Copy link
Member

Merged with #21, deploying to prod soon. Also, I added you as a Proofreader for Korean you can approve your changes as I think you speak Korean natively.

Thanks.

@joshika39 joshika39 linked a pull request Aug 17, 2024 that will close this issue
@rivercory
Copy link
Author

@joshika39 Why did you reset Korean translation?

@joshika39
Copy link
Member

Heyy! I forgot that I could tell you here! So, I know you're native but there's a native korean guy in our team too, and he asked me to not to enable it yet due to translation inaccuracies.

I wanted to ask you to review it once again and typing it in by hand if possible. It felt a little like machine translation.

Your translation should be still in crowdin! If it's not there I'm gonna put it back asap. I didn't mean to remove it there!!

Thank you! And sorry!

@joshika39 joshika39 reopened this Nov 11, 2024
@joshika39
Copy link
Member

Hey there @rivercory!

I hope you're doing great! I restored the Korean translations. The website's language handling is being restructured, and as soon as that's done, regional languages (e.g., simplified and traditional Chinese) will be supported.

In the meantime, I'd like to kindly ask you to do one more revision on the language and not use machine translations. If you did indeed type everything, then I apologize for the misunderstanding.

Thanks,
Joshua

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants