Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for React 19 types in AuthProvider #637

Open
devth opened this issue Jan 8, 2025 · 0 comments
Open

Support for React 19 types in AuthProvider #637

devth opened this issue Jan 8, 2025 · 0 comments

Comments

@devth
Copy link

devth commented Jan 8, 2025

Version info

React: 19

Firebase: 11.0.2

ReactFire: 4.2.3

Other (e.g. Node, browser, operating system) (if applicable): Node 20

Problem

As of this change to react/@types, reactfire no longer type checks. It errors like:

Type error: 'AuthProvider' cannot be used as a JSX component.
  Its type '(props: PropsWithChildren<{ sdk: Auth; }>) => Element' is not a valid JSX element type.
    Type '(props: PropsWithChildren<{ sdk: Auth; }>) => Element' is not assignable to type '(props: any) => ReactNode | Promise<ReactNode>'.
      Type 'Element' is not assignable to type 'ReactNode | Promise<ReactNode>'.

Expected behavior

It type checks against react 19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant