You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The anti-huffman patch causes this address that doesn't exist to be read:
This seems to always result in the upcoming conditional branch failing. As a result GetStringFromIndex won't skip loading a string that's already been buffered in the text buffer, like it would in vanilla. There's also the danger that different emulators or different textIDs might trigger the conditional branch when the text hasn't been loaded. I suggest replacing the highlighted line:
as this will make the 0x202B6AC literal be loaded into r6 at 0xA244 again, meaning the vanilla functionality is restored. Writing the literal 0x202B6AC still fits immediately before the next function's start.
The text was updated successfully, but these errors were encountered:
The anti-huffman patch causes this address that doesn't exist to be read:
This seems to always result in the upcoming conditional branch failing. As a result GetStringFromIndex won't skip loading a string that's already been buffered in the text buffer, like it would in vanilla. There's also the danger that different emulators or different textIDs might trigger the conditional branch when the text hasn't been loaded. I suggest replacing the highlighted line:
https://github.com/FireEmblemUniverse/SkillSystem_FE8/blob/master/EngineHacks/_FE8EssentialFixes.event#L184
with this:
ORG 0xA244
SHORT 0x4E0D 0x6830 0x4285
and adding
WORD 0x202B6AC
immediately below this line:
https://github.com/FireEmblemUniverse/SkillSystem_FE8/blob/master/EngineHacks/_FE8EssentialFixes.event#L195
as this will make the 0x202B6AC literal be loaded into r6 at 0xA244 again, meaning the vanilla functionality is restored. Writing the literal 0x202B6AC still fits immediately before the next function's start.
The text was updated successfully, but these errors were encountered: