Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c2ea fails on the character editor when negative values are given #8

Open
SpaceToastCoastToCoast opened this issue Aug 6, 2018 · 2 comments

Comments

@SpaceToastCoastToCoast
Copy link

SpaceToastCoastToCoast commented Aug 6, 2018

When running c2ea on the character editor module with any base stat value set to a negative value, c2ea throws an error "OverflowError: can't convert negative int to unsigned", even though the nmm specifies the field as decimal signed (NEDS). Expected behavior is that c2ea converts the negative int to signed when writing.

Since vanilla has some enemy characters with negative bases, this problem comes up quite often. The issue still occurs when using the most up-to-date NMMs from known good repos.

@StanHash
Copy link
Member

StanHash commented Aug 6, 2018

Can't replicate.

That error will be thrown if a field marked unsigned (such as NEDU) is mapped to a negative expression (which should be invalid). Of the "base stats" fields in the most common Character Table NMM, only the Base HP field is (mistakenly?) specified NEDU while all the other ones are specified NEDS, and work fine with negative expressions.

(Relatively unrelated: better error messages might be something we want to work towards in the not-so-far future)

@StanHash
Copy link
Member

#11 adds better error messages when it finds a negative value for an unsigned NMM entry.

ex:

ERROR: in csv `GameData/Tables/Class.csv`, row 11, column 10:
  Cell contains signed number, but corresponding NMM entry is unsigned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants