Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for prefixes #17

Open
JeremyEspresso opened this issue Jun 10, 2021 · 4 comments
Open

Support for prefixes #17

JeremyEspresso opened this issue Jun 10, 2021 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@JeremyEspresso
Copy link
Contributor

I am not sure what the best possible way to implement this would be, however I know that support prefixes "natively" from the library would benefit everyone wanting to use the library.

@FiniteReality
Copy link
Owner

I'll probably implement this as an ICommandParser which decorates a previous ICommandParser instance. However, this would require that the DI container supports decoration... I could borrow a technique I used in one of my work-in-progress libraries, but it wouldn't be ideal, since it effectively means registering and unregistering services as the decorator chain is built.

@JeremyEspresso
Copy link
Contributor Author

JeremyEspresso commented Jun 10, 2021

How about adding a separate attribute for it that could be replaced with or is in addition to the GroupAttribute?

@FiniteReality
Copy link
Owner

Prefixes aren't really part of the command, and a lot of times are configurable; adding them as attributes would make it awkward to configure dynamically at runtime.

@JeremyEspresso
Copy link
Contributor Author

Fair enough.

@FiniteReality FiniteReality added the enhancement New feature or request label Jun 12, 2021
@FiniteReality FiniteReality added this to the 0.3 milestone Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants