Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit config additions #167

Open
pvutov opened this issue Jan 9, 2021 · 1 comment
Open

unit config additions #167

pvutov opened this issue Jan 9, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@pvutov
Copy link
Collaborator

pvutov commented Jan 9, 2021

The following fields should be moved from hardcoded to being in the unit config:

shell explosion fx, shell explosion size
unit explosion size (maybe)
convert move speeds to a sane representation
'prefabAdditions' field that allows adding meshes to the main model, such as turrets Declined: If someone needs to do this, they will have to work with the prefab in Unity anyway. So it is easier to just have that person make a full prefab. This is a rare use case and if we were to support it it would mean extra code, lots of turret prefabs lying around unused in the project, and it won't even work that well since most turret swaps also require hull adaptations IRL (you cant just plop down the turret on a hardpoint and call it a day).

there are many more but I need to remember/have them pointed out to me

@pvutov pvutov added enhancement New feature or request help wanted Extra attention is needed labels Jan 9, 2021
@pvutov
Copy link
Collaborator Author

pvutov commented Jan 23, 2021

Should add an 'inherits' field inside turrets too, to reduce duplication wrt weapons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant