Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClosedSetOfValues does lint a switch over field accesses of different classes that are then instantiated #613

Open
Luro02 opened this issue Oct 8, 2024 · 0 comments
Labels
bug Something isn't working D-hard false-positive A lint triggers on something that is correct.

Comments

@Luro02
Copy link
Collaborator

Luro02 commented Oct 8, 2024

Summary

The code looks something like this:

return switch (Character.toUpperCase(repr)) {
    case PathTile.REPRESENTATION -> {
        boolean isVillage = Tile.isVillageCase(repr);
        yield new PathTile(isVillage, false, map, position);
    }
    case Tile.OBSTACLE_REPRESENTATION -> {
        boolean isVillage = Tile.isVillageCase(repr);
        yield new PathTile(isVillage, true, map, position);
    }
    case ForestTile.REPRESENTATION -> new ForestTile(map, position);
    case TargetTile.REPRESENTATION -> new TargetTile(map, position);
    case SafeZoneTile.REPRESENTATION -> new SafeZoneTile(map, position);
    default -> null;
};

where each class looks like this:

public class PathTile extends Tile {
    public static final char REPRESENTATION = 'P';

    // ...
}

Lint Name

ClosedSetOfValues

Reproducer

<code>
@Luro02 Luro02 added bug Something isn't working false-positive A lint triggers on something that is correct. D-hard labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working D-hard false-positive A lint triggers on something that is correct.
Projects
None yet
Development

No branches or pull requests

1 participant