Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider implementing GetStorageHash method #1050

Open
kjezek opened this issue Nov 19, 2024 · 0 comments
Open

Consider implementing GetStorageHash method #1050

kjezek opened this issue Nov 19, 2024 · 0 comments
Labels
good first issue Good for newcomers s5 scheme 5 - MPT

Comments

@kjezek
Copy link
Collaborator

kjezek commented Nov 19, 2024

At the moment, we do not provide this method, and provide only HasEmptyStotage method that returns bool flag saying if the storage is empty or not.

GetStorageHash returns real Hash of the storge root.

Originally we thought that it is performance prohibitive to allow for computing the storage hash at any time. But Ethereum assures this value only for sealed blocks, and for intermediate results it uses statedb temporal values. We do it with the HasEmptyStorage the same anyway, i.e. it would have been no harm to return the hash and implement original GetStorageHash.

@kjezek kjezek added s5 scheme 5 - MPT good first issue Good for newcomers labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers s5 scheme 5 - MPT
Projects
None yet
Development

No branches or pull requests

1 participant