Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify environment for orb container #320

Open
rbren opened this issue Jan 6, 2020 · 3 comments
Open

Specify environment for orb container #320

rbren opened this issue Jan 6, 2020 · 3 comments
Labels
enhancement Adding additional functionality or improvements pinned Prevents stalebot from removing priority: could Future work depending on bandwidth and availability

Comments

@rbren
Copy link
Contributor

rbren commented Jan 6, 2020

Would be great if we could copy environment variables over from CircleCI over to the orb's executor container

@sudermanjr sudermanjr added the enhancement Adding additional functionality or improvements label Jan 6, 2020
@sudermanjr
Copy link
Member

This would be a really nice feature. Basically specify something like this:

       - rok8s-scripts/kubernetes_e2e_tests:
           pre_script: e2e/pre.sh
           script: e2e/test.sh
           command_runner_shared_env:
             - CI_SHA1
             - AWS_SECRET_ACCESS_KEY
           filters:
             branches:
               only: /.*/
             tags:
               ignore: /v.*/

In this example, CI_SHA1 and AWS_SECRET_ACCESS key would be added to the docker run command for the command runner container and set to the value of env in the circle executor.

@stale
Copy link

stale bot commented Mar 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Marked as stale by stalebot label Mar 6, 2020
@sudermanjr sudermanjr removed the stale Marked as stale by stalebot label Mar 6, 2020
@stale
Copy link

stale bot commented May 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Marked as stale by stalebot label May 6, 2020
@sudermanjr sudermanjr added the pinned Prevents stalebot from removing label May 6, 2020
@stale stale bot removed the stale Marked as stale by stalebot label May 6, 2020
@sudermanjr sudermanjr added the priority: could Future work depending on bandwidth and availability label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements pinned Prevents stalebot from removing priority: could Future work depending on bandwidth and availability
Projects
Status: No status
Development

No branches or pull requests

2 participants