Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping a genSources task in IDEA causes stacktrace spam #1212

Open
Juuxel opened this issue Nov 10, 2024 · 2 comments · May be fixed by #1213
Open

Stopping a genSources task in IDEA causes stacktrace spam #1212

Juuxel opened this issue Nov 10, 2024 · 2 comments · May be fixed by #1213

Comments

@Juuxel
Copy link
Member

Juuxel commented Nov 10, 2024

Reproduction steps:

  1. Run a single-sided gen sources task in IDEA (tested with genClientOnlySources, probably also occurs with merged genSources)
  2. When Gradle starts moves the decompile task after the AW validation task, press the stop button
  3. Watch massive log spam of the same exception

I tested this with Fabric API to be specific, but any project should probably have the same outcome.

@modmuss50
Copy link
Member

Intelij likely uses https://docs.gradle.org/current/javadoc/org/gradle/tooling/CancellationTokenSource.html to cancel the build, and it seems to call Thread.interrupt(), allowing us to know if the task was cancled. Worse case we could maybe catch this error if the build has been canceled.

@modmuss50
Copy link
Member

I think fixing this once and for all really needs a new zip fs implementation, and will be a big job needing changes to both TR and loom. I thought about doing all zip operations in another thread that Gradle cannot touch but this is a lot of added complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants