Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do duplicate names really represent an error? #116

Open
markkramerus opened this issue May 26, 2021 · 1 comment
Open

Do duplicate names really represent an error? #116

markkramerus opened this issue May 26, 2021 · 1 comment

Comments

@markkramerus
Copy link

In trying to convert the UTG IG, GoFSH reports several errors because of duplicate name. Going into the IG itself, it turns out that indeed, there are cases where two value sets have the same name. However, they have different defining URLs. The question is whether that it legal and acceptable practice, or whether the current behavior of throwing out an error message is correct.

Here's an example of two value sets with the same name but different URL:
https://terminology.hl7.org/ValueSet-v2-0719.html
https://terminology.hl7.org/ValueSet-v3-InformationSensitivityPolicy.html

@jafeltra
Copy link
Collaborator

jafeltra commented Sep 6, 2024

In order to avoid logging the error, GoFSH would need to handle creating the two value sets with the same name in a different way. The recommended approach for FSH authors when they encounter a case where they have two resources that need the same name is to create the FSH entity with a unique name (so the value after the ValueSet: keyword needs to be unique). They can then use a rule to set the name to be the true desired value. To avoid the error in GoFSH, GoFSH would need to be updated to use that strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants