Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Phaser version > 2.6 #67

Open
tranquoctoan371 opened this issue Jan 26, 2018 · 7 comments
Open

Does not work with Phaser version > 2.6 #67

tranquoctoan371 opened this issue Jan 26, 2018 · 7 comments

Comments

@tranquoctoan371
Copy link

Error log when using with new version of Phaser:

Uncaught TypeError: Cannot read property 'resolution' of undefined
at new b.CanvasRenderer

Please fix this, EZGUI is awesome

@jjalonso
Copy link

Any future plan to port it to Phaser 3 ?

Thanks

@alaa-eddine
Copy link
Contributor

@jjalonso yes, I'm working on a full refactor for the library.
the current compatibility approach is very bad, when I started it I thouht I'll only have to support one Pixi Version and one Phaser version ... today there are 3 incompatible Pixi versions and 3 incompatible Phaser versions (Phaser 2, Phaser CE and Phaser 3).

so my new approach will use plugins, one for each supported library, the initial goal will be to restore full compatibility with PixiV3, PixiV4, Phaser 2 and Phaser 2 CE using two different plugins.
then extend the compatibility to Phaser 3 using a new plugin.

This approach will also simplify community contributions to support other libraries if they want.

there will be slight impact on the code, since you'll need to explicitely declare which plugin to use (Pixi, Phaser2 or Phaser3) .... but hopefully, there will be no (or minor) breaking changes.

@jjalonso
Copy link

jjalonso commented Jun 21, 2018 via email

@alaa-eddine
Copy link
Contributor

EZGUI will become an abstract library for HTML5 GUI.

The Phaser 3 plugin will use only Phaser 3 API obviously.
other plugins like Pixi for example, will use their own APIs.

The idea is to keep GUI creation logic completely separated from the rendering. this way I can support different rendering libraries/Game engines .... and if one of them introduce a breaking change, it won't break the others, I'll just have to update its plugin.

@jjalonso
Copy link

jjalonso commented Jun 21, 2018 via email

@alaa-eddine
Copy link
Contributor

well EZGUI is not that big, and I also use it in some professional gaming projects for customers, this is how I'm funding it somehow :), and this is why I'm not abandonning it.

obviously it's never simple to keep maintaining such projects, but hopefully, if the new version is well structured and used by more people, I'll maybe get some contribution from other developers :)

@jjalonso
Copy link

jjalonso commented Jul 10, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants