Update report next steps copy

[jamesdeanexpensify]

Background

Coming from this conversation, there are some incorrect next steps showing on reports. We need to fix that.

Details

The two updates below should be made to both NewDot and OldDot:

• The next steps on an empty report should read Waiting for <user> to add expense(s).
• The next steps on an open report with scheduled/delayed submit set to manual should read Waiting for <user> to submit expense(s).

Screenshot

Here's an example of where the next steps are incorrect in NewDot currently:

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-20 05:50:49 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The next steps on an empty report should read Waiting for to add expense(s).
• The next steps on an open report with scheduled/delayed submit set to manual should read Waiting for to submit expense(s).

What is the root cause of that problem?

Feature update

What changes do you think we should make in order to solve the problem?

For this case:

App/src/libs/NextStepUtils.ts

Lines 112 to 114 in 177dd5e

	case CONST.REPORT.STATUS_NUM.OPEN:
	// Self review
	optimisticNextStep = {

1. The empty report has been handled by default.

2. Add a condition for open report with scheduled/delayed submit set to manual:

!harvesting?.enabled && autoReportingFrequency === CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE

And modify optimisticNextStep.message to Waiting for <user> to submit expense(s).

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

Update the NextStepUtilsTest for the default (the (1)) case here and the manual submit case here