Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Sign in - The loading icon is not centered on the "Resend link" button #55452

Open
1 of 8 tasks
lanitochka17 opened this issue Jan 18, 2025 · 2 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 18, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.87-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause-Internal Team

Action Performed:

Prerequisite
Sign in to new dot on web with a new Gmail account but do not validate it
Navigate to hybrid iOS
Enter the email address you used to sign in on web and click on next
Navigate to your Gmail inbox and wait for the validation link to arrive to your Gmail address
Click on the "Click this magic link" in the inbox

Expected Result:

The user is navigated back to the app and the loading icon is centered on the "Resend link" button

Actual Result:

The loading icon not is centered on the "Resend link" button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Image

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 18, 2025
Copy link

melvin-bot bot commented Jan 18, 2025

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@dominictb
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

The loading icon not is centered on the "Resend link" button

What is the root cause of that problem?

The loading spinner position is initialized when the button initializes:

But the button initialize bounds value is static, which means it wouldn't update when its content changes. So since the button content is changed from Next (in email input view) to Resend link, the loading spinner center position is not updated accordingly.

What changes do you think we should make in order to solve the problem?

Move the loading spinner center logic to layoutSubviews here which will always be called when the button's layout changes.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants