Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of pcntl_signals makes it unpossible to run on windows in the future. #156

Open
kdankert opened this issue Jun 1, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@kdankert
Copy link
Member

kdankert commented Jun 1, 2021

Describe the bug
As 0.99.22 included signal handling to shutdown the server on ctrc-c, it is not possible to run evosc in the furture as pcntl is not available on windows and won't get released as well most likely.

As pcntl is not compatible with windows, the EscRunCommand fails due to implementing the SignalableCommandInterface from Symphony.

It fails with the message Unable to subscribe to signal events. Make sure that the pcntl extension is installed and that "pcntl_*" functions are not disabled by your php.ini's "disable_functions" directive..

As it is EvoSC goal to be compatible, I suggest the fix imeplemented in the attached PR.

Expected behavior
EvoSC should not fail to start because of pcnt extensions not being loaded. Instead workarounds or windows alternatives should be used on windows.

EvoSC (please complete the following information):

  • EvoSC-Version: [e.g. 0.87.x] (get with php esc version) 0.99.22
  • Game: TM2020

When using git (please complete the following information):

  • Current-Commit: [e.g. bb3eefb] (get with git rev-parse HEAD) 8a220f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant