Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Combobox, Input Time Zone] - simplify matching text highlight styling #11173

Closed
2 of 5 tasks
ashetland opened this issue Dec 30, 2024 · 5 comments
Closed
2 of 5 tasks

[Combobox, Input Time Zone] - simplify matching text highlight styling #11173

ashetland opened this issue Dec 30, 2024 · 5 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Milestone
2025-01-30 - 3.0....

Comments

@ashetland
Copy link

ashetland commented Dec 30, 2024 •
edited by jcfranco
Loading

Check existing issues

Description

For consistency across components, we could simplify the matching text styling to remove the bg color change:
CleanShot 2024-12-30 at 10 28 07@2x

Acceptance Criteria

Matching text only has a font weight increase without the background color.

Relevant Info

Related to #11154

cc @driskull @jcfranco @SkyeSeitz @macandcheese @matgalla

Note: this should also leverage utils added in #11155 and also add a shared mixin if styles align as well (see #11155 (comment)).

Which Component

Combobox, Input Time Zone

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@ashetland ashetland added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 30, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Dec 30, 2024
@jcfranco jcfranco added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible label Dec 30, 2024
@jcfranco
Copy link
Member

I'm all for simplifying, but I’d like to get @emmilaakso212's thoughts on this, as the combobox/input-time-zone item match background color change is based on their design specs.

@driskull driskull mentioned this issue Dec 30, 2024
Merged
@emmilaakso212
Copy link

@ashetland is this due to the impending style changes for selection in Calcite? I'm ok with it as long as the font weight increase is from regular/text to bold. Here's a quick mock:
Screenshot 2025-01-02 at 3 40 43 PM

@jcfranco jcfranco self-assigned this Jan 2, 2025
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. p - medium Issue is non core or affecting less that 60% of people using the library and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 2, 2025
@jcfranco jcfranco added the estimate - 2 Small fix or update, may require updates to tests. label Jan 2, 2025
@jcfranco jcfranco mentioned this issue Jan 2, 2025
Merged
@ashetland
Copy link
Author

@emmilaakso212 Yes. This simplification was also requested for Autocomplete (#11154) and it makes sense to be consistent across components.

jcfranco added a commit that referenced this issue Jan 3, 2025
@jcfranco
feat(combobox, input-time-zone): highlight text matches consistently (#…
75f54de 
…11193)

**Related Issue:** #11173 

## Summary

This also introduces a mixin for shared text highlighting styles.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned jcfranco Jan 3, 2025
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 4, 2025
@geospatialem
Copy link
Member

Verified in 3.0.0-next.89:

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

No branches or pull requests
5 participants
@jcfranco @geospatialem @emmilaakso212 @DitwanP @ashetland