Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[combobox-item-group] group item text should be highlighted when a filter matches it #11172

Open
2 of 6 tasks
driskull opened this issue Dec 30, 2024 · 6 comments
Open
2 of 6 tasks
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.

Comments

@driskull
Copy link
Member

Check existing issues

Actual Behavior

Group text is not highlighted.

image

Expected Behavior

Group text is highlighted matching filter text

Reproduction Sample

https://codepen.io/Matt-Driscoll/pen/zxOENKN?editors=1000

Reproduction Steps

  1. open the codepen
  2. notice group text isnt highlighted

Reproduction Version

3.0.0-next

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

N/A

@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 30, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Dec 30, 2024
@driskull
Copy link
Member Author

cc @ashetland for design figma update

@driskull driskull added the design Issues that need design consultation prior to development. label Dec 30, 2024
@ashetland
Copy link

As of now, the group itself isn't selectable so this might be working as expected. Related issue #7734.

@driskull
Copy link
Member Author

driskull commented Dec 30, 2024

I don't think its expected because we show all the child results when a group is matching the filter text

@ashetland
Copy link

ashetland commented Dec 30, 2024

I'd like to better understand the history of including the group label in the filtering. Many (most?) other systems don't include it. See Spectrum as just one example: https://react-spectrum.adobe.com/react-spectrum/ComboBox.html#static-items. I can filter with "Apple" or "Banana", but "Fruit" returns no results. This feels somewhat expected to be because I cannot choose all the "Fruit" here, only one of them. "Fruit" and "Vegetable" are used for visual grouping only.

CleanShot 2024-12-30 at 13 40 22@2x
CleanShot 2024-12-30 at 13 40 33@2x
CleanShot 2024-12-30 at 13 40 45@2x

@driskull
Copy link
Member Author

@ashetland heres another related issue currently in progress: #7702

@ashetland
Copy link

Apparently it made sense then! 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

2 participants