calcite-action ARIA attributes

[vivzhang]

Check existing issues

• I have checked for existing issues to avoid duplicates and reviewed the Accessibility page for guidance.

Summary

Remove the aria-disabled, aria-busy and aria-pressed attributes on calcite-action. Please ignore the request for aria-label, the Hub team will address that by passing in a unique value for the label property for their use case.

Original AMP issues:
11242
11244

Actual Behavior

1. aria-disabled, aria-busy and aria-pressed attributes rendered on the button inside calcite-action
2. aria-pressed stays as false even when the button is clicked (via calcite-action: the aria-pressed attribute in the component does n't convey the correct state of the collapse and expand of the calcite-action-group.. #11110):

Expected Behavior

1. No aria-disabled, aria-busy and aria-pressed rendered on the button inside calcite-action
2. aria-pressed should convey the correct state. When the collapse /expand is pressed, it should change to true and vice-versa.

Reproduction Sample

https://codepen.io/vivzhang/pen/rNXVWBo

re: item 2 in actual/expected behavior from #11110:

1. Inspect the calcite-action element

2. Note element does not provide the correct aria-pressed information on clicking on collapsing /expanding button.

Reproduction Steps

1. Open the devtool console
2. Inspect the calcite-action component
3. You should see the aria-disabled and an aria-busy attributes rendered on the button element

Reproduction Version

3.12.1

Working W3C Example/Tutorial

No response

Relevant Info

related: #10706

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

• @esri/calcite-components
• @esri/calcite-components-angular
• @esri/calcite-components-react
• @esri/calcite-design-tokens
• @esri/eslint-plugin-calcite-components

Esri team

Arcgis Hub

[jcfranco]

Some notes:

• aria-disabled – this should be addressed in today's release via fix(action): prefer disabled in favor of aria-disabled #10367
• aria-busy – this was added here Enhancement: CalciteAction - add loading and disabled properties calcite-app-components#357

[driskull]

I think we need to research more why aria-busy on an action is a problem. Would we need another property added to action to allow aria-busy to be set? like a loadable property?

I would expect this would apply to other components where aria-busy is being used.