Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per Plugin Flags Section #1975

Open
Peepersoak opened this issue Dec 28, 2022 · 2 comments
Open

Per Plugin Flags Section #1975

Peepersoak opened this issue Dec 28, 2022 · 2 comments
Labels
status:pending Pending acceptance or closure. type:feature-request Request for something new

Comments

@Peepersoak
Copy link

The Problem

One problem I have is that when I added many new flags and I also have other external plugins that have their own flags, it is kinda hard to check which flags belong to which plugin since I believe these flags are ordered by their name, not by the time they got registered,

A Solution

Maybe you can make these flags have their own section, it will still be the same but instead of naming it as general Thirdy Flags, you can name it like === Flags === per plugin.

Example: I have 3 plugins that register their own flags, when I do /rg flags this will show at the last page

===== Virus Flags =====
allow-virus ---------- allow deny
virus-damage ------- unset custom
.....
===== Custom Mobs Flags ======
damage -------------- unset custom
health ---------------- unset custom
.....
===== Villager Market Flags ======
....

Alternatives

No response

Anything Else?

No response

@Peepersoak Peepersoak added status:pending Pending acceptance or closure. type:feature-request Request for something new labels Dec 28, 2022
@Joo200
Copy link
Collaborator

Joo200 commented Dec 28, 2022

That's currently not possible, we don't track which plugin added flags to WorldGuard.

To add this information to the FlagRegistry we would have to make some breaking changes. the flag registry is currently in the core package without any Bukkit reference so there is no easy way to pass your plugin too.

@wizjany
Copy link
Collaborator

wizjany commented Dec 28, 2022

i've seen a bunch of plugins just prefix their flags with an abbreviation so they get grouped. ultimately though
a) plugins aren't going to get attached to flags (not just because there's no bukkit dep, but because plugins can share flags), but we might at some point in the future use namespaced ids (though as mentioned breaking change, so not any time soon) and
b) i am rather against adding more headers to the list since they are kinda visually cluttery, especially if you have a lot of plugins that add few flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:pending Pending acceptance or closure. type:feature-request Request for something new
Projects
None yet
Development

No branches or pull requests

3 participants