Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework event handling #1439

Closed
octylFractal opened this issue Jul 15, 2020 · 2 comments
Closed

Rework event handling #1439

octylFractal opened this issue Jul 15, 2020 · 2 comments
Labels
status:accepted Will be fixed / added to WorldEdit, eventually type:bug Incorrect behavior, not working as intended

Comments

@octylFractal
Copy link
Member

octylFractal commented Jul 15, 2020 •
edited
Loading

Right click handlers are broken in Fabric/Forge, and because I think it is due to how Mojang now sends the packets, it will not be fixed without changes from Mojang. Right clicking a block fires twice, once as "right click block" and once as "right click item". We could use a raytrace to see if a RCI is really a RCB, and ignore it. We could implement the occasionally discussed timer system. Not sure what we really want to do here.

Left click air is also broken right now, needs a more consistent solution on all platforms, or an official notice that it simply doesn't work.
@octylFractal octylFractal added type:bug Incorrect behavior, not working as intended platform:forge platform:fabric Specific to the Fabric platform status:accepted Will be fixed / added to WorldEdit, eventually labels Jul 15, 2020
@wizjany
Copy link
Collaborator

wizjany commented Jul 15, 2020

I think this affects bukkit as well to some extent.

@wizjany wizjany mentioned this issue Nov 15, 2020
Closed
@octylFractal octylFractal removed platform:fabric Specific to the Fabric platform platform:forge labels Nov 15, 2020
This was referenced Jan 3, 2021
Closed
Closed
Closed
@dragonmaus dragonmaus mentioned this issue May 25, 2022
Open
@octylFractal
Copy link
Member Author

Fixed long ago by #2153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:accepted Will be fixed / added to WorldEdit, eventually type:bug Incorrect behavior, not working as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wizjany @octylFractal