Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow instances to be pulled from other repositories #172

Open
Galaucus opened this issue Jun 2, 2021 · 6 comments
Open

Allow instances to be pulled from other repositories #172

Galaucus opened this issue Jun 2, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@Galaucus
Copy link

Galaucus commented Jun 2, 2021

I and a team of others are working on https://github.com/Endless-Sky-Pirate-Campaign/endless-sky

Being able to manage installs of this branch using ESLauncher2 would smooth over our work greatly. I believe MCO mentioned something about needing to change how artifacts are handled to make this work.

@MCOfficer
Copy link
Member

What's your expectation as to how this should be configured? like, how would a person tell the launcher to use an alternative repo?

Being able to manage installs of this branch using ESLauncher2 would smooth over our work greatly. I believe MCO mentioned something about needing to change how artifacts are handled to make this work.

Yes, the artifact unblocker currently has the ES repo hardcoded. refs #140

@Galaucus
Copy link
Author

Galaucus commented Jun 2, 2021

Currently, when installing a new instance, you can pull from PR# or continuous. If another option were added below allowing the user to supply a URL to a valid ES repository to pull from that might do the trick.

@MCOfficer MCOfficer added the enhancement New feature or request label Jun 2, 2021
@samrocketman
Copy link
Contributor

samrocketman commented Apr 24, 2022

I could open a pull request for this designed like #272. Would this be acceptable @Galaucus @MCOfficer ?

I could also add an option for user to provide their own personal access token.

@Galaucus
Copy link
Author

No objections here.

@Zitchas
Copy link
Member

Zitchas commented Apr 20, 2023

This would be very useful to have, and it'd render the need to do things like creating a PR to the main repository just so that ESL2 can pick it up unnecessary.

@Crystal-RainSlide
Copy link

Another option would be just: allow install from a downloaded Endless Sky release file / downloaded plugin.

Then one can just source their instance from literally any place they want.

Also this enables offline installs.

@MCOfficer MCOfficer mentioned this issue Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants