Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation for time to drain WEP capacitor seems to be incorrect #751

Open
chennin opened this issue May 13, 2024 · 2 comments
Open

Calculation for time to drain WEP capacitor seems to be incorrect #751

chennin opened this issue May 13, 2024 · 2 comments
Labels
beta Bug that is present in beta bug Where the data or feature exists, but doesn't work properly

Comments

@chennin
Copy link

chennin commented May 13, 2024

When comparing TTD WEP, I noticed a discrepancy. For testing, we used Stock Python (7E distro, two pips to WEP, two fixed 1F pulse lasers).

coriolis shows a TTD of 2m39s

image

EDSY shows 1m44s

image

testing ingame shows about 1m46s, which is pretty far off coriolis. Far enough that it doesn't look like a rounding error.

I also noticed the issue with a Python Mk2 and multicannons.

I don't fully understand the code, but I did find where I think it is: coriolis and EDSY.

If coriolis is overestimating the TTD then I have definitely been misjudging some builds' viability.

@alex-williams alex-williams added bug Where the data or feature exists, but doesn't work properly beta Bug that is present in beta labels May 14, 2024
@alex-williams
Copy link
Collaborator

Confirmed, saw the test in EDCD Discord. Link provided to code that does the calculation is correct, calculation breaks somewhere and needs to be investigated.

@alex-williams
Copy link
Collaborator

This is because Coriolis assumes 25% per pip of the 100% value on recharge. This is a problem for ENG and SYS values as well, because the game doesn't use these set values. I need to sus out why EDSY gets it 'almost' right and integrate that in Coriolis when making the calculations.

@alex-williams alex-williams pinned this issue Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Bug that is present in beta bug Where the data or feature exists, but doesn't work properly
Projects
None yet
Development

No branches or pull requests

2 participants