Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize to Tray broken in 5.11.1 #2256

Closed
2 tasks done
Rixxan opened this issue Jun 9, 2024 · 0 comments · Fixed by #2257
Closed
2 tasks done

Minimize to Tray broken in 5.11.1 #2256

Rixxan opened this issue Jun 9, 2024 · 0 comments · Fixed by #2257
Assignees
Labels
Milestone

Comments

@Rixxan
Copy link
Contributor

Rixxan commented Jun 9, 2024

Please complete the following information:

EDMC Version:

  • 5.11.1+1a12288f.DIRTY

OS Details:

  • Operating System: Windows 10
  • Version: 10.0.19045
  • Machine: AMD64
  • Python Version: 3.11.9

Environment Details

  • Detected Locale: English_United States
  • Detected Encoding: 1252
  • Journal Directory: C:\Users\david\Saved Games\Frontier Developments\Elite Dangerous
  • Game Version: 4.0.0.1805
  • Game Build: r302250/r0
  • Using Odyssey: False
  • Journal Dir Lockable: True

Describe the bug

In 5.11.1, a handover occurred from the older/out of date infi.systray to a more updated fork, simplesystray. This worked for the most part, however, a few edge cases showed this fork was not as drop-in a replacement as we were lead to believe.

Notably, the open_window function to deiconify EDMC via the tray now requires 2 arguments, systray and an "id" value which is not well documented but defaults to 1023.

To Reproduce
Steps to reproduce the behavior:

  1. Open EDMC
  2. Minimize, with the system tray enabled
  3. Right-Click "Open" or double-click on the tray icon
  4. EDMC does not re-open

Expected behavior
EDMC should reopen when this button is selected.

Additional context
This is a blocking error for any user who minimizes to systray.
Please Confirm the Following...

Logs
EDMarketConnector-debug.log
debuglog.txt

@Rixxan Rixxan added the bug label Jun 9, 2024
@Rixxan Rixxan added this to the Pre-6.0 Changes milestone Jun 9, 2024
@Rixxan Rixxan self-assigned this Jun 9, 2024
@Rixxan Rixxan pinned this issue Jun 10, 2024
@Rixxan Rixxan modified the milestones: Pre-6.0 Changes, 5.12 Jun 10, 2024
@Rixxan Rixxan linked a pull request Jun 10, 2024 that will close this issue
@Rixxan Rixxan closed this as completed Jun 17, 2024
@Rixxan Rixxan unpinned this issue Jun 17, 2024
@github-project-automation github-project-automation bot moved this to Closed (Fixed) in Bug Triage Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed (Fixed)
Development

Successfully merging a pull request may close this issue.

1 participant