-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy number assessment subtree proposal (SO, EFO) #1404
Comments
Dear @mbaudis , I see that there are no recent comments in the related SO ticket, so I suppose that you'd like the terms added in EFO as placeholders. Please let me know if this is not (or no longer) the case. I'm just back from sick leave and haven't looked into the SO thread closely yet, but if desired, I'll be happy to try to add the terms above in time for the next EFO release. We could fine-tune them if needed before the release after that. Best wishes, |
@paolaroncaglia From my POV it is important to go ahead to have this represented as a set of concepts which can then be expanded upon if necessary; we've had a lot of discussions in GA4GH Beacon & VRS and having these terms would be very helpful in supporting some upcoming developments. |
Thanks @mbaudis for confirming. I'll work on this ticket this week, and will post updates here when ready. |
@paolaroncaglia I have updated the term tree slightly, w/ one addition and some re-labeling:
|
@mbaudis thanks. FYI, I plan to add the branch under EFO IAO:0000030 'information entity', which is broader than 'measurement'. |
@mbaudis also, I can't label the new term for SO:nnnn03 as 'copy number variation' as it would clash with the existing EFO:0004798. I can't easily relabel EFO:0004798 because it's used by GWAS, so I'll label the new term as 'copy number variation information' (with a related synonym "copy number variation"). All of this may not be ideal, but it's the best I can come up if you'd like all terms to be in the same branch (e.g., EFO has 'ploidy' under 'quality'...). |
@paolaroncaglia Alternatives:
... ? "Relative" would be the most specific for what this wants to express ...). I'm not sure if the "information" would express the meaning that some type of CNV was observed. |
@mbaudis I'll go with |
@mbaudis diff here if you wish to take a look and/or add further info: https://github.com/EBISPOT/efo/pull/1421/files |
(EFO release is scheduled for Monday morning...) |
@paolaroncaglia Great - thanks! One suggestion: Adding a synonym "homozygous deletion" to |
@mbaudis sure, will do later today. And will then update ticket with new term IDs, for the record. |
@mbaudis I've added basic definitions and your ORCID to all the new terms, plus the suggested synonym, as per (bottom part of) https://github.com/EBISPOT/efo/pull/1424/files. They'll be public with the next EFO release scheduled for Monday January 17th. If further changes are desired, please feel free to open a new ticket for the following EFO release. While the checks run on the final pull request, here are the new terms' IDs and labels: EFO_0030063 (copy number assessment) Best, |
This request is for a subtree which probably should reside in SO and has been submitted for consideration there. However, advice or placement elsewhere is wished for :-)
AFAIK EFO's copy number variation is aimed at the measurement, not at representing the resulting qualities.
There is a definite need for a reference set of "relative genomic copy number" classes as discussed in GA4GH VRS and ELIXIR hCNV.
Preferred term label
(genomic) copy number assessment
Synonyms
Copy number variation analysis
Textual definition
Result of genomic copy number assessment of a genomic element or region
Proposed term hierarchy
This is a copy of the three documented in the SO issue.
Attribution
0000-0002-9903-4248
The text was updated successfully, but these errors were encountered: