Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package builds disable Windows notifications due to regression from Dec 2022 #7025

Closed
derekbruening opened this issue Oct 7, 2024 · 0 comments · Fixed by DynamoRIO/drmemory#2527
Closed

Package builds disable Windows notifications due to regression from Dec 2022 #7025

derekbruening opened this issue Oct 7, 2024 · 0 comments · Fixed by DynamoRIO/drmemory#2527
Assignees
@derekbruening
Labels
OpSys-Windows Usability

Comments

@derekbruening
Copy link
Contributor

While working on #7024 I was surprised to see no popups even in debug build with our package releases. It turns out -msgbox_mask is set to 0 even in debug build in our packages! This is due to a regression from PR #5769 which added AUTOMATED_TESTING to our packages.

We need to change that to instead use a targeted new separate variable to disable zlib.
@derekbruening derekbruening self-assigned this Oct 7, 2024
@derekbruening derekbruening mentioned this issue Oct 7, 2024
Open
derekbruening added a commit that referenced this issue Oct 8, 2024
@derekbruening
i#7025: Restore msgbox_mask package defaults
149ef73 
Replaces the AUTOMATED_TESTING set in package builds by PR #5769 with
a new DISABLE_ZLIB CMake option to accomplish the goal of disabling
the zlib found on these VMs while avoiding turning off msgbox_mask.
The disabling by default of msgbox_mask in packages has caused many
users to fail to obtain error information and has led to confusion
with silent errors.

Fixes #7025
@derekbruening derekbruening mentioned this issue Oct 8, 2024
Merged
derekbruening added a commit that referenced this issue Oct 9, 2024
@derekbruening
i#7025: Restore msgbox_mask package defaults (#7030)
a15656a 
Replaces the AUTOMATED_TESTING set in package builds by PR #5769 with a
new DISABLE_ZLIB CMake option to accomplish the goal of disabling the
zlib found on these VMs while avoiding turning off msgbox_mask. The
disabling by default of msgbox_mask in packages has caused many users to
fail to obtain error information and has led to confusion with silent
errors.

Tested: built a cronbuild based on this branch and downloaded it to the
Windows VM used for #7024.
I ran this:
```
C:\Users\bruening\DynamoRIO-Windows-10.93.20004>bin64\drrun -- msg
<Application C:\Windows\system32\msg.exe (3892).  Out of memory.  Program aborted.  Source I, type 0x0000000000000001, code 0x00000000c000001c.>
```

And confirmed a messagebox popped up: thus showing that `-msgbox_mask`
is *not* set to 0 anymore.

Issue: #7025
derekbruening added a commit to DynamoRIO/drmemory that referenced this issue Oct 9, 2024
@derekbruening
Restore msgbox_mask package defaults
d1cb060 
Replaces the AUTOMATED_TESTING set in package builds by PR #2474 with
the new DISABLE_ZLIB CMake option added by
DynamoRIO/dynamorio#7030. This fixes a regression where msgbox_mask
was set to 0 by default in packages, which caused many users to fail
to obtain error information and has led to confusion with silent
errors.

Fixes DynamoRIO/dynamorio#7025
@derekbruening derekbruening mentioned this issue Oct 9, 2024
Merged
derekbruening added a commit to DynamoRIO/drmemory that referenced this issue Oct 9, 2024
@derekbruening
Restore msgbox_mask package defaults (#2527)
f62daf1 
Updates DR to
[a15656a0c](36a6d23).
Replaces the AUTOMATED_TESTING set in package builds by PR #2474 with
the new DISABLE_ZLIB CMake option added by
DynamoRIO/dynamorio#7030. This fixes a regression where msgbox_mask was
set to 0 by default in packages, which caused many users to fail to
obtain error information and has led to confusion with silent errors.

Tested:
Built
https://github.com/DynamoRIO/drmemory/releases/tag/cronbuild-2.6.20005,
unzipped it, and confirmed it pops up a message box by default on the
machine where DynamoRIO/dynamorio#7024 is hit.

Fixes DynamoRIO/dynamorio#7025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbruening derekbruening

Labels
OpSys-Windows Usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore msgbox_mask package defaults DynamoRIO/drmemory
1 participant
@derekbruening