-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release DynamoRIO v9.0.0 #5145
Comments
I may try to implement a libunwind version of #2414 but would not be able to put SEH64 in there in time so it should not gate the release since it would not be an all-platform feature. |
The other thing is that contributors added externally-triggered attach support (Window: #725 PR #5075; Linux: #38 PR #5019) which is a major feature that we could list for 9.0, but there is no test at all for Linux which makes it hard to claim it works. @M3m3M4n if you could add an attach test we could then announce attach support for the 9.0 release. @OrBenPorath if you get a chance to move the Windows attach test off the flaky list that would be great. |
I'm quite tight on time until the end of the year. Will try to add the tests in my free time. |
@M3m3M4n the attach feature is causing confusion with users who try to use it and complain that it's broken: https://groups.google.com/g/dynamorio-users/c/0n_cgKDPM_M/m/nRLdlKQQAwAJ?utm_medium=email&utm_source=footer Would be great if you could help reply to questions like this, and help clearly mark it as experimental in the docs since it seems to not work everywhere |
Hi @M3m3M4n, per my understanding there are 2 ways to use wrrap for any client application. Suppose I have a client C application testclient which contains some functions like malloc, function1, function2
It does nothing and got stack while testclient is still running
As per https://dynamorio.org/page_deploy.html, following command is used to wrap malloc function I compiled Dynamorio from source code using |
Hi @ManojKumarChauhan, as stated in issue #5054. There is an unknown bug somewhere in the way DR load after injection. Could you build DR with -DDEBUG=ON and see if it works? |
@derekbruening I'm not very familiar with google mail group. Can you tell them to try to build with DDEBUG option enabled as in #5054 for me? Thank you. And I almost done with my company project. If the issue hasn't been fix by then I will see to it. |
Hi @M3m3M4n |
Same issue while compiling Dynamorio in debug mode. When I close client application, drrun gives following error For second case where we give the application name (bin64/drrun -client ./api/bin/libwrap.so 0 -- testclient), it's working only when the function name is malloc because it finds that function from any of the dependent library of libwrap. But if I give any other function which is implemented in testclient then it's unable to find that function because module_load_event doesn't find any module of testclient. |
As the docs say,
Looks like this works fine, with
But, please separate further questions you have about drwrap from this issue: please direct them to the users list https://groups.google.com/forum/#!forum/DynamoRIO-Users for help and discussion and if that discussion concludes there is an underlying bug it would be filed separately (and possibly linked here if it affects the release). |
I replied saying it's still experimental. I tried debug build myself and it crashes there too on my machine.
I put in PR #5227 which hides the feature on Linux since it is not ready yet. As part of the fix for #5054 that hiding can be removed. |
I went and figured out and fixed #5054 along with some other attach bugs and reversed the attach feature hiding. However, there are missing generated code implementations for AArchXX, so this is an x86-only feature until someone implements those. |
Updates the default version number in the sources and package commands to 9.0. Updates the oldest compatible version to 9.0. Issue: #5145
Removes a too-early-and-thus-incorrect call to set_pc_mode_in_cpsr() in execute_handler_from_cache() (transfer_from_sig_handler_to_fcache_return() does this for us at the right time). Removes an incorrect call to dr_set_isa_mode from the cpsr in transfer_from_sig_handler_to_fcache_return(): we want to only set the mode from the target, not the interruption point. Works around QEMU bugs with signals 63 and 64 by using 62 instead in the linux.signalNNNN tests. This allows adding them to the list of tests that work under QEMU. Augments the linux.signalNNNN tests to vary whether the main code and the signal handler are arm or thumb, helping to catch and test signal transition issues. Issue: #4719, #5145 Fixes #5145
I think the only thing left is PR #5235 (unless someone wants to try to get AArch64 attach working) |
Updates the default version number in the sources and package commands to 9.0. Updates the oldest compatible version to 9.0. Adds missing # links in drwrap's doxygen. Adds AArch64 opcode enum ordering to the compatibility breakage list. Issue: #5145
Updates the Download page to list the new 9.0.0 release. Prepares the changelog for new post-9.0 changes. Updates the New Release instructions for a separate docs step. Fixes #5145
Updates the Download page to list the new 9.0.0 release. Prepares the changelog for new post-9.0 changes. Updates the New Release instructions for a separate docs step. Fixes #5145
The prior updates to other workflows seem to have missed the docs one, which we update to 9.0 here. Issue: #5145
The prior updates to other workflows seem to have missed the docs one, which we update to 9.0 here. Issue: #5145
From offline discussion with @derekbruening: we want to release a new version of DR soon. It has been a while since the last release, which was in April 2020. We have made several stability fixes since then, particularly some related to memory management options. As some users hit issues with OOM recently (see discussions on https://groups.google.com/g/dynamorio-users), possibly due to sub-optimal defaults, it'll be good to create a new release.
Task list for some more fixes to include in the release is as follows. We can add more to this list if needed.
Nice to have:
The text was updated successfully, but these errors were encountered: