-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vmarea and heap exit flags not reset on re-init #2571
Comments
s-kanev
added a commit
to s-kanev/dynamorio
that referenced
this issue
Jul 28, 2017
Tested: ctest,internal repro. Fixes DynamoRIO#2571
Re-initializing the same DR library instance is not fully supported yet: #2157 covers the main feature and initial work for full (non-standalone) re-attach. |
Understood, I'm guessing the standalone case is much simpler than #2157 because it touches on fewer static variables. |
derekbruening
pushed a commit
that referenced
this issue
Jul 29, 2017
Resets heap and vmareas exit flags on detach to avoid problems on re-init. Tested: ctest,internal repro. Fixes #2571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This came up in the following case:
Mapping modules then fails because
update_dynamo_areas_on_release()
doesn't remove VM areas thinking it's exiting, because bothvm_areas_exited
andheap_exiting
are still set.The fix is simple, don't statically initialize them, but use the proper _init() functions.
The text was updated successfully, but these errors were encountered: