Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static_detach test failing with extra output after reattach #2188

Closed
derekbruening opened this issue Feb 15, 2017 · 0 comments · Fixed by #2326
Closed

static_detach test failing with extra output after reattach #2188

derekbruening opened this issue Feb 15, 2017 · 0 comments · Fixed by #2326
Assignees
@derekbruening
Labels
Bug-AppFail Component-Tests

Comments

@derekbruening
Copy link
Contributor

After my re-attach CL for #2157:

This is interesting, with the duplicated "Saw some bb events". I thought I
made sure the event callback lists were cleared? Should check that again,
but wouldn't more things have broken if they weren't?

This is in release build: maybe the clearing is debug-only?

http://dynamorio.org/CDash/testDetails.php?test=204327&build=18737

pre-DR init
in dr_client_main
pre-DR start
pre-DR detach
Saw some bb events
re-attach attempt
in dr_client_main
Saw some bb events
Saw some bb events
all done
@derekbruening derekbruening self-assigned this Feb 15, 2017
derekbruening added a commit that referenced this issue Apr 4, 2017
@derekbruening
i#2188: fix callback reattach failure in release build
a5b84a1 
Adds clearing of client callback lists in release build on detach, rather
than being debug-only.  This fixes static_detach test failures.

Fixes #2188
@derekbruening derekbruening mentioned this issue Apr 4, 2017
Merged
derekbruening added a commit that referenced this issue Apr 4, 2017
@derekbruening
i#2188: fix callback reattach failure in release build (#2326)
89073de 
Adds clearing of client callback lists in release build on detach, rather
than being debug-only.  This fixes static_detach test failures.

Fixes #2188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbruening derekbruening

Labels
Bug-AppFail Component-Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#2188: fix callback reattach failure in release build DynamoRIO/dynamorio
1 participant
@derekbruening