From 871e76988c3fb3a3489936afebf1338879e8440b Mon Sep 17 00:00:00 2001 From: Edmund Grimley Evans Date: Tue, 12 Nov 2024 17:51:14 +0000 Subject: [PATCH] i#6624: Warn instead of ASSERT for unexpected SP value. (#7076) Downgrades an assert in vmareas.c:is_on_stack() on a bad stack pointer to a warning, as this is just a surprising application state and nothing DR can't handle. Fixes #6624 --- core/vmareas.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/vmareas.c b/core/vmareas.c index 9658dde7690..ed5075e22c6 100644 --- a/core/vmareas.c +++ b/core/vmareas.c @@ -3910,7 +3910,8 @@ is_on_stack(dcontext_t *dcontext, app_pc pc, vm_area_t *area) ok = get_memory_info(esp, &esp_base, &size, NULL); if (!ok) { /* This can happen with dr_prepopulate_cache(). */ - ASSERT(!dynamo_started); + if (dynamo_started) + SYSLOG_INTERNAL_WARNING("Stack pointer has unexpected value"); return false; } LOG(THREAD, LOG_VMAREAS, 3,