From 5f52afa9ae546c532e5382f1da2d9bfe647f0b80 Mon Sep 17 00:00:00 2001 From: edeiana Date: Wed, 18 Dec 2024 12:53:40 -0800 Subject: [PATCH] Adds link to external-traces-v2, adds signal and uncompleted instr marker to the list of removed markers. --- clients/drcachesim/docs/drcachesim.dox.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/clients/drcachesim/docs/drcachesim.dox.in b/clients/drcachesim/docs/drcachesim.dox.in index 60c02bf8545..59dfc1d94aa 100644 --- a/clients/drcachesim/docs/drcachesim.dox.in +++ b/clients/drcachesim/docs/drcachesim.dox.in @@ -1065,7 +1065,7 @@ A #DR_ISA_REGDEPS #instr_t contains the following information: information is present only for decoded instructions (i.e., #instr_t generated by decode() or decode_from_copy()). This information can be obtained using instr_length(). Be aware that in Google Workload Traces the instruction fetch size of a - #dynamorio::drmemtrace::memref_t# and the instr_length() of the corresponding fetched + #dynamorio::drmemtrace::memref_t and the instr_length() of the corresponding fetched instruction do not match! For convenience reasons we kept the instruction fetch size to be the same as the size of the original ISA instruction. @@ -1083,6 +1083,8 @@ All markers of the original trace are present, except for: - #dynamorio::drmemtrace::TRACE_MARKER_TYPE_SYSCALL_TRACE_START - #dynamorio::drmemtrace::TRACE_MARKER_TYPE_SYSCALL_TRACE_END - #dynamorio::drmemtrace::TRACE_MARKER_TYPE_SYSCALL_FAILED +- #dynamorio::drmemtrace::TRACE_MARKER_TYPE_SIGNAL_NUMBER +- #dynamorio::drmemtrace::TRACE_MARKER_TYPE_UNCOMPLETED_INSTRUCTION Which have been removed. Because tracing overhead results into inflated context switches, the #dynamorio::drmemtrace::TRACE_MARKER_TYPE_CPU_ID values have been modified to @@ -1106,7 +1108,7 @@ v2p.textproto format. The Google Workload Traces can be downloaded from: - - [Google workload trace folder](TODO: add new link to Google Storage Bucket once known) + - [Google workload trace folder](https://console.cloud.google.com/storage/browser/external-traces-v2) Directory structure: - \verbatim