i#2522 strcasestr prototype error: Remove const from result type
#2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The definition of strcasestr is char *strcasestr(const char *text, const char *pattern); but drmemory uses const char *strcasestr(const char *text, const char *pattern); This causes build errors when both /usr/include/string.h and common/utils.h are included in linux. The definition for strcasestr for C has always not had the `const` in the result type (going back to its original addition to glibc in 1997). Thus we're pretty safe in not breaking anything on *nix. The other main use case of drmemory's strcasestr is on Windows, which does not have strcasestr. Tested: $ cmake && make Fixes #2522
|
@xdje42 external users seem to be hitting this issue, would be good to get this merged: https://groups.google.com/g/dynamorio-users/c/WeQqxjwuPDI |
…2522-strcasestr
derekbruening
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition of strcasestr is
char *strcasestr(const char *text, const char *pattern);
but drmemory uses
const char *strcasestr(const char *text, const char *pattern);
This causes build errors when both /usr/include/string.h and common/utils.h are included in linux. The definition for strcasestr for C has always not had the
constin the result type (going back to its original addition to glibc in 1997). Thus we're pretty safe in not breaking anything on *nix. The other main use case of drmemory's strcasestr is on Windows, which does not have strcasestr.Tested:
$ cmake && make
Also, there are failures in the clang and x86 workflows, but comparing the logs before/after
shows all failures pre-exist this patch, no new failures.
Here is the complete audit, all failures are pre-existing.
Recorded (errantly) as i#1938 failures:
Note: The above are marked as expected failures but runsuite_wrapper.pl hardwires the addition of "i#1938" to test output. i#2534
Not currently recorded as expected failures (all i#2491 - vsyscall incorrect assumption):
Fixes #2522