Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to wesnoth.effects for some properties #577

Open
Discontinuum opened this issue Jul 12, 2023 · 1 comment
Open

Consider switching to wesnoth.effects for some properties #577

Discontinuum opened this issue Jul 12, 2023 · 1 comment

Comments

@Discontinuum
Copy link
Contributor

Some properties happen to have a built-in support in wesnoth.effects from 1.14, so maybe we can switch to using built-in ones (although the code in stas.lua probably have to stay for supporting legacy saves).

Among them are vision (apply_to=vision), max_attacks (in docs max_attacks with increase= key while LotI uses add), alignment (LotI items use

[effect]
apply_to=alignment
alignment=chaotic
[/effect]

while Wesnoth docs define the built-in alignment effect as

[effect]
apply_to=alignment
set=chaotic
[/effect]
@Dugy
Copy link
Owner

Dugy commented Jul 12, 2023

Yes, that would make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants