Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuff I have to do for v0.1-DP2 #195

Open
16 tasks done
DrewNaylor opened this issue Apr 6, 2023 · 1 comment
Open
16 tasks done

Stuff I have to do for v0.1-DP2 #195

DrewNaylor opened this issue Apr 6, 2023 · 1 comment

Comments

@DrewNaylor
Copy link
Owner

DrewNaylor commented Apr 6, 2023

See also: #36

These are a few things I copied from that issue that were moved from v0.1-DP1. I also added a few other things I thought of.

Be sure to check the other issues that are similar to what I'm writing here so they can be closed when I'm done. I don't remember which of them I've already written.

  • Add the scrollbar to the All Apps list
  • Remove %c and other unused flags from Exec key values
  • Allow the user to set their accent color in a config file and figure out a way to bind background color values for the All Apps list items and the textbox and button in the Search app. This value will be used as a fallback in case tiles don't have their accent color specified in the layout file (likely startlayout.yaml), but if the accent color is also not specified, it'll fallback to Cobalt. To make things easier, I'll probably use a separate file to store values for accent colors and the theme, probably themeconfig.yaml. Actually, the light theme vs dark theme switching may be a little difficult to do right away, though this code should help when I get around to add light theme support: https://github.com/nullvoid-creations/Jaya/blob/dev/src/Jaya.Shared/ThemeManager.cs (I'm using QML now, though). Eventually I'll also add support for third-party themes.
  • Allow the user to specify their wallpaper file, and whether to use wallpapers at all (standard ones) or tile wallpapers (the ones inside tiles), as well as their preferred icon theme. These will go in the theme config file.
  • [-] If I can get around to it, fix The initial wallpaper implementation has some issues. #194 I don't really want to try to figure this out yet. I'll do it in another version.
  • [-] Switch to using just plain SVG files instead of the icon font (but make sure they can have different colors applied as needed, such as in an app that wants them to be a certain color, or if a user has a theme that changes them to be that color; this can apparently be done with a ColorOverlay but the original SVG file has to be hidden [visible: false]: https://forum.qt.io/topic/75115/qml-svg-change-color/5?_=1681082088719&lang=en-US ; I think this can be handled by setting the icon color and pressed icon color from, say, a developer's side using the round button and from the round button's side [or more likely, in the ButtonBase itself?] using those colors to apply to a ColorOverlay and having the actual original SVG file hidden; maybe it would be a good idea to allow specifying if a monochrome icon is being used, and if so, use the ColorOverlay but if not, just display the image as usual? This could also improve performance as we only need to load one image instead of two, such as on the unpin button) Delayed until a later version as I've managed to fix the icon font in a PR and Qt6.5 has the ColorOverlay thing properly ported.
  • Remove pyyaml from the distributed files if I haven't already (this was done in a recent PR I think)
  • Apply a (configurable) 20% opacity black layer to the background wallpaper to help it stand out and make things easier to read (this is what Microsoft did for things like the lock screen image and background images in Hubs like the Photos Hub). This layer will be configurable to allow things like using colors aside from black (perhaps even allowing using the Accent color and white [white may be an issue unless I have a way to use black text on tiles, thus allowing even more of a "light theme" than the original; that's a good idea, as not everyone can use or likes white-on-darker colors] in addition to black and custom colors?) and changing how opaque the layer is (should that apply to everything that will eventually need the 20% black layer? It would simplify things, but I think it should be just for the lock screen and (Retiled)Start screen backgrounds to allow for customizability by users; the layer will be a standard item that can be used and modified by even other apps, so they can change colors and stuff if they want). This is mentioned in the long document where I wrote a bunch of stuff that'll be eventually added and I'm just going to put it into this version to start with.
    • [-] I have added the config options for color and opacity, but I need to add more to use the Accent color specifically. I think in the Settings app it can be a dropdown with black, Accent color, and custom. The different options will be black, accent, or custom as strings (eventually enums). This will not be added to v0.1-DP2.
  • [-] An option to apply a FastBlur to the background wallpapers in the tiles area would be cool. This would have to be able to be turned off and the blur strength modified. I also mentioned this in that long document. I don't know exactly where this should be applied, maybe under the 20% black layer? Probably also should apply it to the wallpaper image directly so it can be picked up in both wallpaper styles. This will be off by default.
    • [-] This will be delayed until v0.1-DP3 as I still don't have Qt6.5 on my distro, and I doubt most everyone else would, either (unless they're really bleeding edge, like Arch or maybe even postmarketOS? But I want to make sure as many people as possible can use it).
    • [-] Use the new MultiEffect item in Qt 6.5 for the blur and (if it makes sense, otherwise I'll just do a Rectangle with opacity) 20% black layer. (Also delayed until v0.1-DP3, as this is how blur will be implemented.)
  • Use a rectangle for the 20% opacity black layer.
  • Switch to the "Inter" font (I think that's what I decided on). The Semi Light analog is 350 I think. Between Regular and Light, anyway. But I can't really use 350 without manually making my own SemiLight variant somehow, as QML doesn't apparently support variable fonts for most things besides MCUs, according to what I read (switching to Inter is in a PR)
  • Deprecating raw width and height values for tiles in favor of "small", "medium", and "wide" (Deprecate specifying tile width and height instead of "small", "medium", and "wide" to prepare for proper tile sizing with the TilesGrid. #199)
  • Display a popup message on startup if any of the tiles have deprecated raw width and height values set and no TileSize set. We'll know if any of them do with the hasDeprecatedRawTileWidthAndHeightValue or something, and we'll just set a property upon finding one and that'll pop up only one messagebox stating that the user needs to force a save to update their startlayout config file format to the latest version, and it's not being done automatically just to give them a preview of what it'll be. State that any sizes besides the expected values for small, medium, and wide are set to medium. Basically take the print statement I have in the tileslist.py file.
    • It doesn't have the nice transitions, but that's ok. I kinda want to get this version out soon, and I'm sure it's understandable.
  • Add RetiledSettings to the list of folders that get installed via the install script.
    • Would it be a good idea to copy its library to its subfolder, or just the config files? I think copying its library folder would be a good idea.
  • Put the deprecation text in a Flickable so the popup can be shorter and fit on screen. It's almost off the screen on the PinePhone at 200% scale.
  • Copy licenses on installing for clarification (TODO: copy license files when installing. #219)
  • Do the readme for this version
  • Clean up system requirements if I haven't (ehhh it's good enough for now I think)
  • Mention that the Action Center and compositor apps don't get installed even though they're in the release's zip file
@DrewNaylor
Copy link
Owner Author

I'll leave this open so I can transfer the other stuff I didn't want to do yet to a later version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant