Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic UX: close with typo'd args closes the thread immediately #667

Open
didinele opened this issue Oct 19, 2021 · 1 comment
Open

Comments

@didinele
Copy link

Attempted to !close cancel but misspelled the word cancel, as a result, the thread was immediately closed.

This is particularly poor UX, and I feel like arguments given to close should be properly parsed, and, if invalid, the command should error out.

@DarkView
Copy link
Collaborator

This problem arises because close allows for a variety of options and only uses direct checks for those options.
Changing to the in-built command argument system would likely also only complicate matters and not catch invalid arguments because those are simply ignored.
Additionally, some users put their close reasons behind the !close command and retroactively changing that behavior to error out seems impractical.
I would recommend using just the initial letters for short and cancel, so !close c for the time being as it's faster and a lot less error prone. (Yes, the fact that initials also work for cancel should be in the docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New Suggestions
Development

No branches or pull requests

2 participants