Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Set the correct activation events #30

Closed
DrMerfy opened this issue Feb 22, 2022 · 3 comments
Closed

Improvement: Set the correct activation events #30

DrMerfy opened this issue Feb 22, 2022 · 3 comments

Comments

@DrMerfy
Copy link
Owner

DrMerfy commented Feb 22, 2022

Currently we are using * as the activation event, this causes the extension to be slower.

We should set some more specific activation events.

@GitMensch
Copy link
Collaborator

This may relate to #33 - @DrMerfy Did you checked which activation events would be correct?

@DrMerfy
Copy link
Owner Author

DrMerfy commented Apr 1, 2023

Hey @GitMensch probably the best option is to use the onStartupFinished event, it should improve loading performance by some. Another idea would be to let it enable when the toggle command is trigered but that would mean that the user will not have access to the typing mode indicator before triggering the command.

image

Pushed the changes (and a slightly adjusted icon to reflect the project in general) in master. Could you please take a look that it works in your environment as well with the adjusted activation events?

@GitMensch
Copy link
Collaborator

probably the best option is to use the onStartupFinished event

agreed.

LGTM, also for use with remote workspaces; so time to update ChangeLog and release, I think :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants