-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Add support for SQL Server 160 #5
Comments
I second this - I am using Visual Studio 2022 Enterprise, which has sqlpackage 16.x in the program files tree (not x86). If I hand edit publish-dacpac, get-sqlpackagepath and select-sqlpackageversion to allow '16' in the validate sets and add the non-x86 path for vs - then it works beautifully. I've never done this before, but would you let me try to do a pull request for these simple changes? |
@DavidAitken @JohnMerryweatherCooper would you be able to take over this project from me? In recent years I never seem to get the time to dedicate to this project and I hate to be the bottleneck stopping the extension from progressing. If agreeable to you, I will figure out how the extension can be published on Microost Visual Studio Marketplace by yourself or anyone else interested in taking the project over. |
Good morning Dr. John,
Thanks for thinking of me – but frankly my powershell skills are almost none. If this was written in C or Perl and didn’t use a language that hates punctuation (yaml), then I might feel confident enough to help.
In the meantime, I will be happy to track changes on this as I use it, and if someone has a question/request against the code I’ll take a look.
Kind regards,
Dave
From: Dr John Tunnicliffe ***@***.***>
Sent: Friday, June 7, 2024 4:36 AM
To: DrJohnT/PublishDacPac ***@***.***>
Cc: David Aitken ***@***.***>; Mention ***@***.***>
Subject: Re: [DrJohnT/PublishDacPac] [ENHANCEMENT] Add support for SQL Server 160 (Issue #5)
@DavidAitken<https://github.com/DavidAitken> @JohnMerryweatherCooper<https://github.com/JohnMerryweatherCooper> would you be able to take over this project from me? In recent years I never seem to get the time to dedicate to this project and I hate to be the bottleneck stopping the extension from progressing.
If agreeable to you, I will figure out how the extension can be published on Microost Visual Studio Marketplace by yourself or anyone else interested in taking the project over.
—
Reply to this email directly, view it on GitHub<#5 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKPW4YWBZ26QKLSHLGQYCZTZGGLJBAVCNFSM5YOQPALKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMJVGQ3DKNJTGI3A>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Adding 160/16 to the various ValidateParameter calls allowed PublishDacPac to locate SqlPackage 16.x on my machine.
The text was updated successfully, but these errors were encountered: