Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for audio #38

Open
lawndoc opened this issue Nov 28, 2022 · 5 comments
Open

Support for audio #38

lawndoc opened this issue Nov 28, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@lawndoc
Copy link
Collaborator

lawndoc commented Nov 28, 2022

I created a separate issue from #20 because this goes a different route than what was initially suggested. There is an issue open in NoVNC for audio support, and multiple people have gotten it to work through their own means.

This project seems to be a simple way to get audio working. I might test the method out in my fork and see if I can get something working.

If the above method doesn't work or there's noticeable lag between the video and audio, I'll some other methods from the NoVNC issue thread.

@lawndoc lawndoc self-assigned this Nov 28, 2022
@lawndoc lawndoc added the enhancement New feature or request label Nov 28, 2022
@davidnewcomb
Copy link
Collaborator

I added sound support to this project before it was upgraded. You might be able to get something useful from https://github.com/davidnewcomb/docker-tor-browser/tree/vlc

I draw your attention to client.any-tcp.conf, pulse-client.linux-native.conf and pulse-default.pa which are the main configuration files for running sound over native linux pulseaudio or over tcp pulseaudio.

@davidnewcomb
Copy link
Collaborator

I have upgraded my project inline with this one and added support for sound and VLC:
The newer kernel has more support for sound and so it needs slightly less fiddling to get it to work - basically just the pulse audio configuration file.

  1. cp run/pulse-client.any-tcp.conf run/pulse-client.conf
  2. Override options in tor.opts.sh
  3. build

https://github.com/davidnewcomb/docker-tor-browser/blob/vlc2

@lawndoc
Copy link
Collaborator Author

lawndoc commented Mar 31, 2023

Nice work @davidnewcomb! Would you mind opening a PR to this repo from your vlc2 branch?

@michaelmcmillan
Copy link

michaelmcmillan commented Apr 10, 2023

I have upgraded my project inline with this one and added support for sound and VLC: The newer kernel has more support for sound and so it needs slightly less fiddling to get it to work - basically just the pulse audio configuration file.

  1. cp run/pulse-client.any-tcp.conf run/pulse-client.conf
  2. Override options in tor.opts.sh
  3. build

https://github.com/davidnewcomb/docker-tor-browser/blob/vlc2

I've added a PR with @davidnewcomb's changes in his vlc2 branch (#49).

@davidnewcomb
Copy link
Collaborator

Thanks @michaelmcmillan . The branch in my repo (vlc2) included a few extra features that I was still working on, e.g. xclip was included in my (original) vlc branch but I've not been able to get it to work with the current iteration (vlc2). It wasn't quite ready to add it to this project yet.

I have created a branch in this repo called vlc with a slightly updated README that is now ready for testing. I have stripped out the xclip, vim and python3 stuff as well because they are not needed here to get vlc/audio working.

There are a couple of extra environment variables that need to be set up to make it work and so it has meant that I've had to change the way we launch docker with a shell script. This change will mean the README may have to change a bit more to make it flow better.

Please take a look and see if you can get it up and running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants