Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

Logout after 1h #2

Open
Computerkrack opened this issue Aug 31, 2023 · 4 comments
Open

Logout after 1h #2

Computerkrack opened this issue Aug 31, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@Computerkrack
Copy link

Two suggestions:

  1. there is no feedback (e.g. pop up) when you are logged out after the hour
    or
  2. you will not be logged out at all, only if you decide to (in form of a button)
@Dlurak Dlurak added the enhancement New feature or request label Aug 31, 2023
@Dlurak Dlurak transferred this issue from Dlurak/dloolFrontend Aug 31, 2023
@Dlurak
Copy link
Owner

Dlurak commented Oct 6, 2023

Sorry for the late response.
Both are good ideas and I could and will implement.

Not beeing logged out at all wouldn't be good but I think I will use refresh tokens so the browser can automatically request a new JWT-Token Using this method you can manually log out and you can stay logged in for months.

The first idea to give the user some form of feedback is good. While a popup is very disruptive, a small Toast isn't, so I will implement toasts when I find time for it.

Thanks for the feedback :)

@Dlurak
Copy link
Owner

Dlurak commented Oct 6, 2023

In the frontend I just added the notifications.
Later I will also implement refresh tokens. When I've implemented these I will close this issue :)

@Dlurak
Copy link
Owner

Dlurak commented Mar 18, 2024

This codebase is extremely messy and there are fundamental design flaws, it needs a rewrite. I will hopefully finally address this in the rust 🦀 rewrite of the backend

@Dlurak
Copy link
Owner

Dlurak commented Mar 30, 2024

Just some small updates: Actually the new Dlool will be using ElysiaJS and EdgeDB. I'm still very early but this is already fixed in the new version.
Currently it's kind of hard to say how long I will need until everything is migrated...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants