Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stealth scannos term #606

Open
okrick opened this issue Dec 26, 2024 · 2 comments
Open

Stealth scannos term #606

okrick opened this issue Dec 26, 2024 · 2 comments
Labels
future feature New feature or request, but not core

Comments

@okrick
Copy link

okrick commented Dec 26, 2024

One of the Stealth Scanno checks is for \btb with th as a suggested replacement. I was puzzled at why I would want to replace <tb> with th until I realized this was for something like tbe. Perhaps a better search term would be \btb\w.

I feel this is very minor and could be added to a todo list after GG2 leaves beta.

Yes, I rarely use Stealth Scannos. The online PPtxt seems to be better.

@windymilla
Copy link
Collaborator

windymilla commented Dec 27, 2024

Thanks Rick - I just ported the scanno definitions from GG1 across to GG2, and \btb is one of those. I see the problem with it like it is, although your solution needs a little adjustment.
If we search for \btb\w it would find tbe, but if you did the replacement, tbe would go to th (i.e. losing the e).
However, I think it should be possible to use something like \btb(?=\w) so that the extra letter doesn't get included in the match. Some of the other scanno regexes have similar lookahead or lookbehind assertions.

@windymilla windymilla added the future feature New feature or request, but not core label Dec 27, 2024
@okrick
Copy link
Author

okrick commented Dec 27, 2024

You are correct. I missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future feature New feature or request, but not core
Projects
None yet
Development

No branches or pull requests

2 participants