Lack of unit tests #13
Labels
enhancement
New feature or request
Comments
dimitrivlachos
added a commit
that referenced
this issue
Nov 5, 2024
Implement extended dispersion spotfinding Implement a GPU-based version of the extended dispersion spotfinding algorithm. This builds on regular dispersion by making two passes. This allows for the detection of fainter spots by using the first pass to detect candidate spots and exclude them from the background calculation in the second pass. Extended dispersion spotfinding is unavoidably slower than regular dispersion by the fact that it requires two passes. However, the performance gained through massively parallel processing on the GPU should make this a viable option, when needed, even for fast feedback. Create several CUDA kernels to perform the extended dispersion spotfinding algorithm (`threshold.cu`, `erosion.cu`). Refactor the dispersion kernel to share code with extended dispersion. Move common code to `cuda_common.hpp`. Create basic test script for extended dispersion spotfinding. Add an `--algorithm` argument to `spotfinder.cc` along with the necessary code to parse it, allowing for algorithm selection at runtime. Add new files to the CMakeLists.txt file to include them in the build. See also: #12, #13, #14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the tests for the fast-feedback-service rely on a few bash scripts to perform analysis, then manual comparison. This approach is not ideal, as it is prone to error and limits the capability for automated testing.
To improve the testing process, proper unit tests should be developed to replace or supplement these bash scripts. Implementing unit tests will enable better testing and CI integration, provide a more reliable and maintainable testing framework.
The text was updated successfully, but these errors were encountered: