Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I24 serial: have the PMAC program runner check the counter PV #900

Open
noemifrisina opened this issue Nov 13, 2024 · 0 comments
Open

I24 serial: have the PMAC program runner check the counter PV #900

noemifrisina opened this issue Nov 13, 2024 · 0 comments

Comments

@noemifrisina
Copy link
Collaborator

The collection time passed as timeout to complete on the PMAC ProgramRunner is currently calculated from the input parameters (exposure time, laser exposure and delay, number of images) plus the time needed for the PMAC moves plus a buffer. For most short experiments this works well, but for some of the longer collections, it has proven to be difficult to estimate as the buffer needed seems to increase exponentially with the number of blocks. While we should still check that the status PV (BL24I-MO-STEP-14:signal:P2401) goes to zero at the end of the collection - so tha the PMAC is not left in a weird state - we can also check when a collection is over by monitoring the counter PV (BL24I-MO-STEP-14:signal:P2402).

ProgramRunner should check that this PV has already reached the number of frames requested by timeout and if not, continue waiting.

Acceptance Criteria

  • ProgramRunner doesn't complete until the counter PV reaches the expected number of frames.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant