-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linter to enforce import rules #840
Comments
How about "nothing within dodal imports from |
Having just stumbled into making a circular dependency: love it. |
Also |
what if we make 'beamlines' just YAML? 👀 |
That possibility was discussed at the bluesky workshop at NOBUGS. I think if we went that route we would be trying to find a multi-facility solution for loading devices. Currently everyone has rolled their own using either databases, config files, or code-as-config (like dodal). |
Given the feedback on this I think we can say that it's been agreed upon that we do it. Updating acceptance criteria and pulling into next hyperion sprint |
In
mx-bluesky
we have enforced some import rules with a linter DiamondLightSource/mx-bluesky#568. We could do the same withdodal
. The rules will probably be at least:common
doesn't import fromdevices
devices.ixx
doesn't import fromdevices.iyy
Acceptance Criteria
The text was updated successfully, but these errors were encountered: