Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypoMiner object creating #104

Open
vs9h opened this issue May 1, 2022 · 0 comments
Open

Fix TypoMiner object creating #104

vs9h opened this issue May 1, 2022 · 0 comments
Labels
chore Performance upgrade or technical debt

Comments

@vs9h
Copy link
Collaborator

vs9h commented May 1, 2022

Now, to create TypoMiner object you must pass precise algorithm param as algo. But it looks strange, since I have to pull out the preciseAlgorithm from the config, because this is a parameter, not the name of the algorithm (For example, TANE mines FDs, Apriori mines ARs). The real name of the algorithm is TypoMiner (for mining typo FDs).

Secondly, I need to create tasks for mining clusters and specific clusters.
It can be useful to have different constructors:

  1. Create object for mining TypoFDs (need to provide info about the file, precise algorithm, approximate algorithm)
  2. Create object for mining clusters (need to provide info about the file, ratio, radius, typo FD)

Thirdly, I need to mine different representations of the same cluster. Is it possible to add FD creating without table parsing? If it's true, I won't create TypoMiner object in this case and use only TypoMiner static functions. (These functions must be static: FindClustersWithTypos, SquashCluster, FindClustersAndLinesWithTypos). If it isn't possible to create FD without table parsing, I need a third constructor, but that seems odd.

@vs9h vs9h added the chore Performance upgrade or technical debt label May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Performance upgrade or technical debt
Projects
None yet
Development

No branches or pull requests

2 participants