Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about init_dones tensor in a2c_common #277

Open
WSYANGSX opened this issue Mar 15, 2024 · 1 comment
Open

question about init_dones tensor in a2c_common #277

WSYANGSX opened this issue Mar 15, 2024 · 1 comment

Comments

@WSYANGSX
Copy link

hello!
When I was reading a2c_common source code. I find a question. Why we need to initialize self.dones tensor ones? That will mark first translation (s,a,s_,r, done=1). I don't know if this is a mistake. Or I don't understand the code logic correctly.
image

@jiaweiz9
Copy link

That doesn't matter. The real dones are actually returned from env.step(). You can look at play_steps() for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants