I'd be interested in looking into this one

The library we use is react-image-crop, which we wrap with the component:
https://github.com/DemocracyLab/CivicTechExchange/blob/5a0f28ddb62e7dd57ca3baebfcc43f805c807245/common/components/common/upload/ImageCropUploadButton.jsx

@schaferyan Hi, I'm helping with development focus for DemocarcyLab. We've created a DemocracyLab Dashboard and would like to update the status of this issue.

There is an unresoved comment in the PR #911

Changing project thumbnails fails with the following console error:
ImageCropUploadButton.jsx:123 Uncaught TypeError: this.props._onIsCroppingChanged is not a function at ImageCropUploadButton._handleFileSelection (ImageCropUploadButton.jsx:123:16) at FileReader. (FileSelectButton.jsx:71:18)

Are you still working on this? If so, what are the next steps, or what challenges are there to moving forward?
Or is this still an issue/should we close it?
Or, if you just aren't available to work on it anymore, please let me know, and/or unassign yourself
Or something else?

Thanks.

@ddfridley Happy to take this if its still available, which it seems to be.

@Nostromos please consider that we need to make the QA testing as simple as possible - meaning change the least files and lines of code as possible. Also I am working on adding storybook, an environment for running and testing react components. Maybe we can be a good candidate for that. Lets talk more about that when I get back from vacation.

Understood. I think the simplest approach is:

1. Move state to parent,
2. Pass that state's setter to child,
3. Require a completed crop to save and close parent (the parent button text might be Done)
4. Add a required field message if crop is in progress and user attempts to move on ("Click 'Done Cropping' if crop is complete or 'Cancel'" - something along those lines).

Simpler still might be autosaving crop after a short delay and not requiring the "Done Cropping" button to be clicked but I need to look into the cropping library to see if that's possible.

The bigger problem is that I never learned class-based react and vscode seems to hate flow, despite an entirely new profile with TS parsing turned off, flow extension installed, etc. Anyway I'll get that figured out and will put in a PR once I've got something.

@marlonkeating @ddfridley Hey I think I've got it figured out. Can I get perms to push my branch up so I can draft a PR? There's still some testing left to do and a little clean up but should be good to go by EOD today or Monday.