Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show awaiting approval header alert for already-approved projects #1056

Open
marlonkeating opened this issue Oct 21, 2023 · 5 comments · May be fixed by #1108
Open

Don't show awaiting approval header alert for already-approved projects #1056

marlonkeating opened this issue Oct 21, 2023 · 5 comments · May be fixed by #1108
Assignees
@ashwin-sp @HonglinZheng
Labels
Front End Primarily front-end (react/javascript)

Comments

@marlonkeating
Copy link
Contributor

When the project creation workflow is finished, the following message is shown in the top alert bar:
Your project <Project Name> is awaiting approval. Expect a decision in the next business day.

However, even after the project is approved, if the project is edited and the user clicks the final 'Update Project' at the end of the workflow, they still see this message.

Code Location

CivicTechExchange/common/components/controllers/CreateProjectController.jsx

Lines 183 to 187 in e0baf17

let urlArgs: Dictionary<string> = {
projectAwaitingApproval: url.encodeNameForUrlPassing(
project.project_name
),
};

@marlonkeating marlonkeating added the Front End Primarily front-end (react/javascript) label Oct 21, 2023
@ashwin-sp ashwin-sp self-assigned this Mar 11, 2024
@ashwin-sp
Copy link
Collaborator

Checked with @HonglinZheng before taking over

@HonglinZheng
Copy link
Collaborator

Thank you, Ashwin. Let's stay in touch about a potential collaboration. I am glad to help!

@ddfridley ddfridley moved this from Backlog to In progress in DemocracyLab Development and Release Apr 25, 2024
@ddfridley
Copy link
Collaborator

@HonglinZheng Hi, I'm helping with development focus for DemocarcyLab. We've created a DemocracyLab Dashboard and would like to update the status of this issue.

  • Are you still working on it? If so, what are the next steps, or what challenges are there to moving forward?
  • Or is this still an issue/should we close it?
  • Or, if you just aren't available to work on it anymore, please let me know, and/or unassign yourself
  • Or something else?

Thanks.

@ashwin-sp
Copy link
Collaborator

ashwin-sp commented Apr 25, 2024 •
edited
Loading

@ddfridley Sorry I have been busy and couldn't push this early. I am planning to work on this within this week.

The issue is a straightforward fix but the problem exists for Events and Groups as well so I am planning to push the fixes for all along with this.

@ddfridley ddfridley moved this from In progress to Recent Activity in DemocracyLab Development and Release Apr 25, 2024
@ashwin-sp ashwin-sp linked a pull request May 28, 2024 that will close this issue
fix: Approval header now not displayed for already approved entities #1108
Open
@ashwin-sp
Copy link
Collaborator

@ddfridley I have raised a pull request for this. Can you kindly move this to needs PR review section?

@ddfridley ddfridley moved this from Recent Activity to Needs review in DemocracyLab Development and Release May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashwin-sp ashwin-sp

@HonglinZheng HonglinZheng

Labels
Front End Primarily front-end (react/javascript)
Projects
DemocracyLab Development and Release
Status: Needs review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Approval header now not displayed for already approved entities DemocracyLab/CivicTechExchange
4 participants
@marlonkeating @ddfridley @ashwin-sp @HonglinZheng