-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Analytics Cleanup #1069
Comments
I'd love to take on this if its avail. thanks! |
@aatudaboss thanks but this is a second step that I am working on but waiting for the previous step to be deployed in production before I can deploy this one. |
@marlonkeating the google tag changes of #1067 are working great. As a next step, can you disable the GOOGLE_TAGS_ID (currently GTM-MBD5H4V) in production. Then check google analytics and just verify that realtime data is still flowing in -- or let me know and I will look at it. If it's not flowing, then we just put the key back. What this will prove is that the google tag manager data is going to some other google analytics accounts, and not to democracylabs'. FYI @mfrischmuth |
This is a follow on to PR #1067
Open here for instructions
This might get you there: https://analytics.google.com/analytics/web/#/p375510764/realtime/overview
When you see these, it's a success!
Both GOOGLE_PROPERTY_ID, corresponding to gtag in google analytics, and GOOGLE_TAGS_ID corresponding to google tag manager are set in production. Generally we should use only one, but in this case it looks like the GOOGLE_TAGS_ID is not managed by the democracylab google analatics or google tagmanager account. This may correspond to a previous volunteer's account.
We should turn off GOOGLE_TAGS_ID (but keep the ID in a safe place) and verify that we still get google analytics that we are using now. If we stop getting realtime data, then there is some other issue and we can put back the GOOGLE_TAGS_ID .
Rework metrics.js to work with google analytics,
Google analytics is already sending some information, and we should consider the effect of redundancy and overload
for some things, mertics.js passes userId in events, Google has additional legal requirements if you are passing user identifiable information and we need to discuss at the high level if we need this and have the right stuff in our terms and condidtions.
PR Gtag#1034 #1067 made a specific change to common/components/controllers/CorporateHackathonController.jsx , and this should be factored out or updated to match the new solution.
The text was updated successfully, but these errors were encountered: