You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I work for @qnx and have recently been looking into supporting cJSON on QNX 7.1 and 8.0 after some of our customers requested it. Changes that enable cross-compiling cJSON for QNX are only a few lines long and confined to files CMakeLists.txt and tests/CMakeLists.txt. Build files reside separately in QNX's GitHub repository for ports.
I noticed that, per the contributing guidelines, pull requests should typically be raised against the develop branch. However, the develop branch seems to be many commits behind master, and given the urgent need of these changes, I would request permission to raise a PR directly to the master branch.
Why a PR against master?
The develop branch is many commits behind master, and merging to develop could delay the deployment of these updates.
These changes are customer-driven and would benefit from being available in production soon.
I am happy to follow any additional steps you recommend and will be available for any required revisions to the PR :)
The text was updated successfully, but these errors were encountered:
The cJSON source licensing allows you to make whatever modifications you wish and include them in your product. Why not just use your modifications? Is there a reason that the changes need to be part of the cJSON master branch in order for you to use them?
In our project, we have some of our own custom changes which we use as part of our product.
Hi!
I work for @qnx and have recently been looking into supporting cJSON on QNX 7.1 and 8.0 after some of our customers requested it. Changes that enable cross-compiling cJSON for QNX are only a few lines long and confined to files
CMakeLists.txt
andtests/CMakeLists.txt
. Build files reside separately in QNX's GitHub repository for ports.I noticed that, per the contributing guidelines, pull requests should typically be raised against the
develop
branch. However, thedevelop
branch seems to be many commits behindmaster
, and given the urgent need of these changes, I would request permission to raise a PR directly to themaster
branch.Why a PR against
master
?develop
branch is many commits behindmaster
, and merging todevelop
could delay the deployment of these updates.I am happy to follow any additional steps you recommend and will be available for any required revisions to the PR :)
The text was updated successfully, but these errors were encountered: