Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise PR against master for customer-requested changes #892

Open
sarunnaik opened this issue Sep 17, 2024 · 1 comment
Open

Raise PR against master for customer-requested changes #892

sarunnaik opened this issue Sep 17, 2024 · 1 comment

Comments

@sarunnaik
Copy link

Hi!

I work for @qnx and have recently been looking into supporting cJSON on QNX 7.1 and 8.0 after some of our customers requested it. Changes that enable cross-compiling cJSON for QNX are only a few lines long and confined to files CMakeLists.txt and tests/CMakeLists.txt. Build files reside separately in QNX's GitHub repository for ports.

I noticed that, per the contributing guidelines, pull requests should typically be raised against the develop branch. However, the develop branch seems to be many commits behind master, and given the urgent need of these changes, I would request permission to raise a PR directly to the master branch.

Why a PR against master?

  • The develop branch is many commits behind master, and merging to develop could delay the deployment of these updates.
  • These changes are customer-driven and would benefit from being available in production soon.

I am happy to follow any additional steps you recommend and will be available for any required revisions to the PR :)

@mbratch
Copy link

mbratch commented Dec 26, 2024

The cJSON source licensing allows you to make whatever modifications you wish and include them in your product. Why not just use your modifications? Is there a reason that the changes need to be part of the cJSON master branch in order for you to use them?

In our project, we have some of our own custom changes which we use as part of our product.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants