Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full_numbers_no_ellipses not working in v2 #586

Open
mulgaBrian opened this issue Mar 15, 2024 · 5 comments
Open

full_numbers_no_ellipses not working in v2 #586

mulgaBrian opened this issue Mar 15, 2024 · 5 comments

Comments

@mulgaBrian
Copy link

mulgaBrian commented Mar 15, 2024

I have found that the plugin does not get the parameters (page,pages).
My fix is to get these from the table itself.
I removed the parameters and added this.

var pageinfo = table.page.info();
var page = pageinfo.page;
var pages = pageinfo.pages;

Everything now works as expected.
It looks like this will apply to all the pagination plugins.

HTH
Brian

@AllanJard
Copy link
Contributor

Hi Brian,

Yes, the paging plugin API were updated a bit for v2. Thanks for posting your workaround! I'll take some time soon to update the paging plugins in this repo.

@bytestream
Copy link
Contributor

@AllanJard was the input paging plugin updated to work with the new 1.10 or 2 API ?

@AllanJard
Copy link
Contributor

No - I haven't had a chance to work on that yet. Pull requests welcome though. If not, I'll get to it sometime soon - hopefully this week or next all being well.

@Unleashed2k
Copy link

@AllanJard Any news? Any news would be helpful, thank you :)

@AllanJard
Copy link
Contributor

Not yet. It will be ASAP though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants